Skip to content

fix: clean up some type mismatches + doc typos in AnkrProvider#57

Open
famouswizard wants to merge 1 commit intoAnkr-network:mainfrom
famouswizard:patch-1
Open

fix: clean up some type mismatches + doc typos in AnkrProvider#57
famouswizard wants to merge 1 commit intoAnkr-network:mainfrom
famouswizard:patch-1

Conversation

@famouswizard
Copy link

found a few small inconsistencies in the AnkrProvider class while browsing the SDK - nothing major, just a bit of type cleanup and fixing some misleading JSDoc comments.

changed:

  • fixed wrong @returns types in getNFTMetadata and getNFTHolders (they were returning Request instead of Reply).
  • updated getNftTransfers to use the correct request type GetNftTransfersRequest (was using the generic GetTransfersRequest).
  • synced up getAccountBalance docs with its actual return type.
  • general formatting cleanup - removed a few redundant spaces and kept consistent method style.

no logic changes, no behavior impact - just making the types and docs honest again.


how to test

run a quick build or tsc --noEmit.
no runtime difference, everything compiles cleanly and IDE hints are now accurate.


why

because accurate types are like good coffee - you don’t notice it when it’s perfect, but you definitely do when it’s not ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant