fix: clean up some type mismatches + doc typos in AnkrProvider#57
Open
famouswizard wants to merge 1 commit intoAnkr-network:mainfrom
Open
fix: clean up some type mismatches + doc typos in AnkrProvider#57famouswizard wants to merge 1 commit intoAnkr-network:mainfrom
famouswizard wants to merge 1 commit intoAnkr-network:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found a few small inconsistencies in the
AnkrProviderclass while browsing the SDK - nothing major, just a bit of type cleanup and fixing some misleading JSDoc comments.changed:
@returnstypes ingetNFTMetadataandgetNFTHolders(they were returningRequestinstead ofReply).getNftTransfersto use the correct request typeGetNftTransfersRequest(was using the genericGetTransfersRequest).getAccountBalancedocs with its actual return type.no logic changes, no behavior impact - just making the types and docs honest again.
how to test
run a quick build or
tsc --noEmit.no runtime difference, everything compiles cleanly and IDE hints are now accurate.
why
because accurate types are like good coffee - you don’t notice it when it’s perfect, but you definitely do when it’s not ☕